Add Nerfstudio renderer module for preview rendering#15
Open
wdxia134 wants to merge 1 commit intoaukilabs:developfrom
Open
Add Nerfstudio renderer module for preview rendering#15wdxia134 wants to merge 1 commit intoaukilabs:developfrom
wdxia134 wants to merge 1 commit intoaukilabs:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Context:
A need was identified to integrate Nerfstudio for preview rendering in the project. The previous approach did not handle rendering efficiently or offer an easy way to upload rendered images. This PR addresses that gap by introducing a new module.
Changes:
nerfstudio_renderer.pyinsrc/preview_renderer/.Technical Reasoning:
By invoking Nerfstudio via subprocess, the integration maintains the modularity of the process and isolates rendering from other components, ensuring better maintainability. The upload function ensures rendered content is immediately accessible for further steps.
Testing Notes:
Feedback welcome!